search

v923z / micropython-builder

Ready-to-run firmware files with micropython and ulab
MIT License
29 stars 13 forks source link

Create pico_w.sh #6

Closed sakluk closed 1 year ago

sakluk commented 1 year ago

Based on discussion on: https://github.com/v923z/micropython-builder/issues/5 I created a pull request for Raspberry Pi Pico W board.

Not tested, but guess that only thing to modify compared to pico.sh is the port parameter: build_rp2 "PICO" => build_rp2 "PICO_W"

sakluk commented 1 year ago

I have now tested it on my local Linux environment. Works.

v923z commented 1 year ago

@sakluk You closed the PR before I had a chance to merge it. You should re-open this, and the next one, otherwise, I can't make it part of the workflow.

Actually, what would be even better is, if you created a new PR, where you have addes both your changes. In a single PR.

sakluk commented 1 year ago

@v923z sorry for the mesh. I'm learning how to use git.

I realized that I tried to pull request before I had tested in my own branch. Now I'm learning how to test the system in my fork. When I tried to create a pull request against master in my fork, I got error message the new pico_w.sh script was not found. I'm looking a way to fix that problem...