Initial upload from local source

vCheckReport / vCheck-NSX

vCheck-NSX is an NSX-focussed reporting tool that can give you a periodic (i.e. Daily) look into the health of your platform.

https://vcheck.report/

MIT License

18 stars 6 forks source link

Initial upload from local source #1

Closed davehocking closed 7 years ago

davehocking commented 7 years ago

Hi there, here's the local source I've been working on, ready for review. It looks like I may have worked on an older version of the style.ps1 file, so there are some diffs there that I don't recognise.

Sneddo commented 7 years ago

Yeah, there's a bit of work to clean this up.

Currently, based on a quick skim through:

The HTML Config GUI won't work (probably)
Some of the changes for PowerCLI Core have been reverted

We can probably just replace vCheck.ps1 and vCheckUtils.ps1 with a copy from the dev branch of vCheck-vSphere to cover some of this.

I'll merge it anyway, and we can work on fixing these.

davehocking commented 7 years ago

I tinkered with vCheck.ps1 to auto-load PowerCLI modules, that can easily be removed, the Style changes can be re-done easily enough, if it makes it easier than trying to merge my stuff in?

Sneddo commented 7 years ago

I don't think it will be too much effort, just little things like you mentioned.

I do think minimising changes to vCheck.ps1 is good, so we can easily merge updates from the other repos more easily. Otherwise it's just a matter of testing and squishing any bugs :)

davehocking commented 7 years ago

Agreed. Bedtime now, catch up with this tomorrow :)