search

vaadin / cdi

CDI Integration for Vaadin
Apache License 2.0
41 stars 56 forks source link

test: Fixes CdiVaadinServletTest, broken due to missing servlet registration (#420) #421

Closed mshabarov closed 1 year ago

mshabarov commented 1 year ago

Fixes CdíVaadinServletTest which broke due to vaadin/flow#15188 which assumes that vaadin servlet has been registered when Atmosphere is being initialized

(cherry picked from commit 7c29686a4b3e29b78b3af7293887155286e9971d)

mcollovati commented 1 year ago

validation build is failing with npm error: Dependency ERROR. Check that all required dependencies are deployed in npm repositories

mcollovati commented 1 year ago

~Locally, tests fails with errors like Could not create Container payara~ Never mind, I forgot to activate the profile

mshabarov commented 1 year ago

The build uses com.vaadin:flow-maven-plugin:23.0-SNAPSHOT:build-frontendwhich is a bit of strange, I'll check

vaadin-bot commented 1 year ago

This ticket/PR has been released with Vaadin 23.3.0.rc1 and is also targeting the upcoming stable 23.3.0 version.