Closed mshabarov closed 1 year ago
MPR branch - https://github.com/vaadin/multiplatform-runtime-internal/tree/migrate-to-jakarta Vaadin 24 + Spring Boot 3 + MPR 7 (V8) smoke testing project - https://github.com/mshabarov/spreadsheet-mpr/tree/V24
Test project works as expected.
MPR 7.0 jakarta migration has been done in branch convert-jakarta
, here is the pull request https://github.com/vaadin/multiplatform-runtime-internal/pull/645 , which is failing because:
spreadsheet-v8
test module fails, it gives (I use version 2.1.1):
[INFO] --- vaadin-maven-plugin:8.17-SNAPSHOT:compile (default) @ spreadsheet-demo ---
[INFO] auto discovered modules [com.vaadin.addon.spreadsheet.demo.DemoWidgetSet]
[INFO] Using com.vaadin:vaadin-client-compiler version 8.0.0
[INFO] Compiling module com.vaadin.addon.spreadsheet.demo.DemoWidgetSet
[INFO] [ERROR] Hint: Check that your module inherits 'com.google.gwt.core.Core' either directly or indirectly (most
often by inheriting module 'com.google.gwt.user.User')
The following tests are flaky on my machine, not sure this is a real error though:
ManualPushWithNoUiCallsIT
AbstractPushTest::checkMessagesAppearing
LayoutCalculationIT.openVaadinDialog_resizeDialog_tabContentHasResized
LayoutCalculationIT.reopenVaadinDialog_tabContentIsShown
Vaadin 7 based tests are disabled until we get the jakarta version of Vaadin 7.
Note: Vaadin 8.17.1 has been staged for testing, and Vaadin 8.17-SNAPSHOT is available as well. So from 8.17.1 onwards Framework features "Jakarta-ization", which can be used by replacing the vaadin-server and vaadin-compatibility-server dependencies with vaadin-server-mpr and vaadin-compatibility-server-mpr, respectively. To be tested further.
Is there a timeline for official Vaadin 8 Jakarta Support for extended Maintenance? @TatuLund
Looking at the comment in 8.18.0's release notes, currently it looks kinda un-official by using MPR.
This is only needed for MPR 24+, and is NOT guaranteed to work as generic Jakarta support (even though it does so at the moment) as we may add MPR specific functionality or even hard MPR dependencies in the future.
Source: https://github.com/vaadin/framework/blob/master/CHANGELOG-VAADIN8.md
MPR 7.0.0.alpha2 includes both V7 and V8 with Jakarta now. The issue is closed. @knoobie good question! Could you please transfer it to the V7,8 framework GH repo issue tracker?
8.17.1
has been staged for testing, and Vaadin8.17-SNAPSHOT
is available as well. So from8.17.1
onwards Framework features "Jakarta-ization", which can be used by replacing thevaadin-server
andvaadin-compatibility-server
dependencies withvaadin-server-mpr
andvaadin-compatibility-server-mpr
, respectively. To be tested further.