vaadin / framework

Vaadin 6, 7, 8 is a Java framework for modern Java web applications.
http://vaadin.com/
Other
1.78k stars 730 forks source link

LocalDateToDateConverter converts to wrong values (for very old dates) #10665

Open cdir opened 6 years ago

cdir commented 6 years ago

The LocalDateToDateConverter in vaadin 8.3.1 converts the value too naive.

Depending on the current time zone there might be some time gabs because of different calendar adjustments. For example in TimeZone "Europe/Berlin" there was a time gab of 0:06:32h on April 1st 1893. (https://www.timeanddate.com/time/zone/germany/berlin?year=1893). That means: If you enter a LocalDate of 1893-04-01 it is converted to Date 1893-04-04 00:06:32.

Further time gab of several days was on 1582-10-15 (Julian Calendar to Gregorian Calendar).

A quite good explanation and a hint for correct conversion is given on https://stackoverflow.com/questions/44801189/how-to-convert-util-date-to-time-localdate-correctly-for-dates-before-1893/44802513

stale[bot] commented 6 years ago

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

scardanzan commented 4 years ago

This is related to JDK-8061577 and that is marked as won't fix. Its probably not great to have behavior beyond the standard implementation on general converters. If you need to handle those special cases you can create your own converter.

stale[bot] commented 4 years ago

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!