search

vaadin / portlet

Portlet support for Vaadin Flow
https://vaadin.com
Other
2 stars 3 forks source link

Use DeploymentConfigurationFactory #107

Closed caalador closed 5 years ago

caalador commented 5 years ago

Implement VaadinContext for portlet and use the DeploymentConfigurationFactory to get the correct configuration using flow-build-info and other fixes that maybe done to the factory.

requires vaadin/flow#6820

Fixed #103

This change is Reviewable

vaadin-bot commented 5 years ago

SonarQube analysis reported 8 issues

Watch the comments in this conversation to review them.

6 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL VaadinPortlet.java#L349: Remove usage of generic wildcard type. rule
  2. MAJOR VaadinPortlet.java#L172: Call "Optional#isPresent()" before accessing the value. rule
  3. MAJOR VaadinPortlet.java#L193: Define and throw a dedicated exception instead of using a generic one. rule
  4. MAJOR VaadinPortlet.java#L302: "NullPointerException" will be thrown when invoking method "getViewContext()". rule
  5. MINOR VaadinPortlet.java#L297: Remove this use of "getParameterMap"; it is deprecated. rule
  6. MINOR VaadinPortlet.java#L304: Remove useless curly braces around statement rule