search

vaadin / vaadin-gradle-plugin

Gradle plugin for Vaadin 14 applications. Takes care of front-end build, helps to configure repositories and to create various project and file templates.
Apache License 2.0
31 stars 9 forks source link

Support vaadin 17 #82

Closed hfazai closed 4 years ago

hfazai commented 4 years ago

Gradle Kotlin Vaadin are Awesome :-D

This PR Fixes #69, Fixes #50 and Fixes #56

We are planning to start a projet with gradle and vaadin 16 and actually vaadin-gradle-plugin doesn't support vaadin 15/16.

So this PR is to add support of V15/16

Edit : This PR will also target supporting vaadin 17

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

mvysny commented 4 years ago

@hfazai excellent work with the PR! Thank you so much for your hard work. Also excellent notice to update the cleanVaadin task to delete those TS-related files. Thank you, I really appreciate it :+1:

I can see that Vaadin 16 doesn't support the nodeVersion and nodeDownloadUrl customizations, and that the PR removes these bits. However, in the future when Vaadin 17 is released, we will need to re-add those bits back.

Therefore, I propose the following. Since Vaadin 17.0.0.beta1 is already out and it is expected that Vaadin 17 will be released sometime this month or the next one, how about targeting Vaadin 17 with this PR instead? That way we can keep the nodeVersion and nodeDownloadUrl customizations and we don't have to remember to add those back.

After all, Vaadin 16 is going to be deprecated in 3-4 months. @mstahv thoughts?

hfazai commented 4 years ago

@mvysny Thanks! it's my real pleasure to make this contribution and to collaborate with you :-)

I also think that it's better to target Vaadin 17. I see in Vaadin Roadmap that V17 is planned to be released in Sept2020.

So for now I'll convert this PR to Draft and when finish all needed changes to target v17 I'll mark it as ready for review :)

mvysny commented 4 years ago

Let's wait for @mstahv to give a final OK

mvysny commented 4 years ago

@hfazai thank you so much! The PR would have been merged already under normal circumstances, but we need first to configure github workflows and other things properly, so that e.g. every commit triggers a build and merge checks. Please be patient - the PR will be merged tomorrow latest :+1:

hfazai commented 4 years ago

Thanks alot @mvysny I understand :) I enjoyed colloborating with you @mvysny @mstahv @caalador . Thanks for the remarks and guidelines to add this feature. :tada: :tada: :tada: