vacla / Watson

Updated Watson that displays LogBlock and CoreProtect query results in 3D.
MIT License
84 stars 8 forks source link

[Bug] Incompatibility with Tweakeroo #15

Closed StarsDown64 closed 3 years ago

StarsDown64 commented 3 years ago

Using tweakeroo with watson seems to break a lot of things. The visualization completely breaks for watson when the mod is installed. Also, as mentioned in maruohon/tweakeroo#197, watson breaks the chat timestamps feature for <x> y like messages, but not other messages.

Versions: Fabric: 1.16.5 0.11.3 Fabric API: 0.32.0+ Malilib: 0.10.0-dev.21+arne.5 Watson: 1.8.3-dev.20210221.142930 Tweakeroo: 0.10.0-dev.20210309.164640 (These were the only mods installed while testing)

vacla commented 3 years ago

I already read the issue yesterday that you made on tweakeroo, i contacted the dev about it, with visualization do you just mean that the message don't look as it should or is there something else not looking correct?

StarsDown64 commented 3 years ago

The actual box outlines for the coreprotect logs don't appear anymore. For example session logs: I see them in chat and that's fine, but the boxes that usually show up at the coords they logged on/off at are missing.

vacla commented 3 years ago

Can you send a screenshot of what it is exactly?

StarsDown64 commented 3 years ago

Imgur As you can see, the outlines and the pink cross are only visible without tweakeroo installed.

vacla commented 3 years ago

interesting, will take a look at it later, and so will talk about it with the dev of tweakeroo about it

vacla commented 3 years ago

Is it possible to send your config files from watson and tweakeroo?

StarsDown64 commented 3 years ago

https://www.dropbox.com/s/7ll0whui9o9ef8h/config.zip?dl=1 Mostly default, just some disables on binds I don't use and a few others. Edit: I didn't include the malilib but it's def full default. Didn't even know it had a config

vacla commented 3 years ago

I got the bug fixed in dev, will upload tomorrow the fix to curseforge, ill leave this issue open till i upload it and got confirmation that it worked

vacla commented 3 years ago

I talked with the dev of tweakeroo and we both agreed that Tweakeroo causes it, not sure when yet, but they will fix it, i'll keep this also updated when that gets released

StarsDown64 commented 3 years ago

I have another "symptom" to report. Team messages no longer show up when I send them. If someone else sends them I can see them, but my own don't show up. I got the error traceback as well: gist

vacla commented 3 years ago

Can you enable debug in Watson settings and send the latest.log again since it will give me more debug info about what happend there

StarsDown64 commented 3 years ago

https://gist.github.com/StarsDown64/24752098cea1309e2fb59310b756d49f

StarsDown64 commented 3 years ago

Quick update, I decided to try disabling chat highlighting and it fixed the chat issues. The mod still doesn't draw coreprotect results in the world but at least that means the chat highlighter may be the issue. I don't really know why I had it on, there's nothing in my highlight list (Maybe that's the issue?)

vacla commented 3 years ago

If you disable the time message it should show rrsults again (will be fixed in tweakeroo sidr) and the chat issue is watson fault, ill fix that later

vacla commented 3 years ago

Is this okay? if it goes from

-> [Test] Test message to [Test] Test message like https://gyazo.com/f03fa65ec1dc36723d47836cd1ab1208

StarsDown64 commented 3 years ago

Personally, I'm always of the opinion that one's mod shouldn't prevent vanilla features from working. I would rather see you fix the issue than create some band-aid. Specifically for me, I've just turned off the chat highlighting since I don't need it. Now the teammsg is showing and I'm also getting timestamps for messages again. It's up to you what you want to do, but I'd want to fix the issue, not run around it.

vacla commented 3 years ago

it was more that i made a fault that it didn't start checking a character after another character was in the text, will try still to add the "->" characters

vacla commented 3 years ago

i seem to got a fix on my side, for timestamps issue that is a tweakeroo related issue

vacla commented 3 years ago

@StarsDown64 I updated on my side what i could fix, fixed, if masa fixes the chat issue on tweakeroo side, it would work again how you want it

StarsDown64 commented 3 years ago

The teammsg is fixed, but results are still not being drawn in the world. At this point I'm just going to stop using tweakeroo because I have other mods I can use for the same effect. I think I'm going to stop participating in this thread because I've given you all the information I have. You should probably fix the issue of results not being drawn to the screen but I suppose you want have me nagging you anymore lol. Sent you a friend request on discord if you want to keep working or maybe work live some.

vacla commented 3 years ago

Issue fixed, this was caused by advanced chat.

StarsDown64 commented 3 years ago

This was not caused by advanced chat. Advanced chat just happened to have the same issue. This is still (last time I checked) a problem with Tweakeroo.