search

vaga / hugo-theme-m10c

A minimalistic (m10c) blog theme for Hugo
https://themes.gohugo.io/hugo-theme-m10c/
MIT License
471 stars 294 forks source link

Bugfix: Removed cached resources hiding SCSS recompilation failures #40

Closed Sam-Martin closed 4 years ago

Sam-Martin commented 4 years ago

I finally figured out why my Hugo site was themed correctly on my laptop and not when built using travis. I created an assets/css/_extra.scss with my own styling which worked perfectly on my laptop. However when built it from Travis CI it didn't work at all, instead using the default styling.

I nearly went mad trying to figure out why. I even tried the same Docker image on both my laptop and travis, but it still worked on my laptop and not travis because I hadn't cleared the resources folder that was generated when I ran it on my laptop originally!

Turns out, if you have a cached resources folder, Hugo (non extended, what I installed on travis/docker) will just used the pre-cached css and not throw an error. But Hugo extended (which I had installed on my laptop) will do what it should and regenerate it regardless of whether it's present or not.

Sorry, this isn't really relevant to whether or not merging the PR is a good idea, I just had to tell some-one!

Thanks so much for making this theme btw, love it!

vaga commented 4 years ago

I must keep the resources/ directory to publish it in the Hugo showcase (https://github.com/gohugoio/hugoThemes/blob/master/README.md#adding-a-theme-to-the-list) and for non extended hugo binary.

It's not the first issue/PR regarding Hugo extended and resources cache, I should add something into README.md to warn on this. (like a FAQ section)

Thanks for your PR. I'm always glad to know someone use this theme. :)

Sam-Martin commented 4 years ago

No way! That requirement combined with the fact that hugo doesn't show a warning (much less an error) when it's using cached resources is super user unfriendly! I'll see if there's any outstanding feature request to add a warning to non-ext Hugo when it runs with cached SCSS from a theme.

Thanks for the explanation!