search

vaibhavsingh97 / random-word

This is a simple python package to generate random english words
https://pypi.org/project/random-word/
MIT License
123 stars 25 forks source link

added a change in readme for installing in python3.5 and python3.6 #11

Closed nightwarriorftw closed 5 years ago

vaibhavsingh97 commented 6 years ago

@nightwarrior-xxx Thanks for the PR 💯 IMO, it's not needed as pip handles the installation for both python 2.x and python 3.x. If your system has the default python 2.x it will install the package automatically. Ref: https://pip.pypa.io/en/stable/installing/

Also, before opening PR, It would be great if you open Issue first, as this PR holds no value as it's not referencing to the issue it fixes. Thanks

nightwarriorftw commented 6 years ago

Please check the README.md once again And I was getting problem while installing using pip ,he was showing an error that he could not install using this version so I have to use "pip3 " for installing

vaibhavsingh97 commented 6 years ago

@nightwarrior-xxx Can you please open issue with relevant screenshots and information

nightwarriorftw commented 6 years ago

Error while installing thorugh "python3 setup.py install" screenshot from 2018-07-13 00-41-18

vaibhavsingh97 commented 6 years ago

@nightwarrior-xxx Yeah, It's because of config.py is missing. Please check https://github.com/vaibhavsingh97/random-word#development for more details. Also, I fixed pip issue and thanks for reporting it :)

vaibhavsingh97 commented 5 years ago

closing since there is no update. Feel free to open new PR