vaidik / commentjson

Add JavaScript or Python style comments in JSON.
MIT License
104 stars 25 forks source link

Updated to latest lark-parser #51

Open Eeems opened 3 years ago

Eeems commented 3 years ago

Newer versions of lark-parser have added pyinstaller support, which is something that I would like. lark-parser 0.8.1 is also supposedly backwards compatible now. In theory you should be able to allow anything > 0.8.0?

Apteryks commented 3 years ago

Seems to build fine with lark-parser 0.9.0 on GNU Guix. The test suites passes, at least the part I can run (the Python package on Guix ships without the "test" module, so the ones relying on it are removed during the packaging).

starting phase `check'
running "python setup.py" with command "test" and parameters ()
running test
running egg_info
writing commentjson.egg-info/PKG-INFO
writing dependency_links to commentjson.egg-info/dependency_links.txt
writing requirements to commentjson.egg-info/requires.txt
writing top-level names to commentjson.egg-info/top_level.txt
reading manifest file 'commentjson.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'commentjson.egg-info/SOURCES.txt'
running build_ext
test_dump (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_dump_throws_exception (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_dump_with_kwargs (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_dumping_parsing_simple_string (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_dumps (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_dumps_throws_exception (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_dumps_with_kwargs (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_load (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_load_throws_exception (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_load_with_kwargs (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_loads (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_loads_throws_exception (commentjson.tests.test_commentjson.TestCommentJson) ... ok
test_loads_with_kwargs (commentjson.tests.test_commentjson.TestCommentJson) ... ok

----------------------------------------------------------------------
Ran 13 tests in 0.069s

OK
Eeems commented 3 years ago

@vaidik do you plan on looking into this at some point? Or would a PR be acceptable?

jonringer commented 2 years ago

also, lark-parser 1.0.0 was released,