search

vala-lang / valadoc-org

Build tools used to generate valadoc.org
https://valadoc.org
GNU Lesser General Public License v2.1
84 stars 25 forks source link

make sidebar padding more consistent #120

Open hyuri opened 7 years ago

hyuri commented 7 years ago

Icons & text feel too close together on the horizontal axis as well as too close to the left edge of the page, to me. Difference in spacing(or padding) between horizontal and vertical axis is very pronounced. Looking at Files' sidebar, for reference: difference in spacing is way less pronounced -- barely noticeable. Biggest difference is, in Files, padding from the left edge is bigger.

Images attached, for reference.

Roughly playing around, just for checking, I got the results I was looking for by changing: Added: "padding: 4%" to #navigation-content Changed: "padding: 4%" in #sidebar .navi_main a (pictured in "Valadoc Sidebar - After (Suggested).png")

What do you think?

To better see the difference, click to open the images.

Before (Current) valadoc sidebar - before current

After (My suggestion) valadoc sidebar - after suggested

Files: files sidebar

benwaffle commented 7 years ago

IDK, does it really matter if the icons are closer to the edge? I'd rather see more results on the page without scrolling

ZanderBrown commented 7 years ago

Don't think it makes much difference and it's a slippery slope to try and emulate native Gtk styling as not everyone has the same theme (i think it's elementary in this example?)