search

valeriansaliou / sonic

🦔 Fast, lightweight & schema-less search backend. An alternative to Elasticsearch that runs on a few MBs of RAM.
https://crates.io/crates/sonic-server
Mozilla Public License 2.0
20.11k stars 578 forks source link

List all words from the bucket control operator #293

Closed trkohler closed 2 years ago

trkohler commented 2 years ago

resolve https://github.com/valeriansaliou/sonic/issues/177

trkohler commented 2 years ago

if possible, could you please add hacktoberfest label to the PR? because otherwise it won't be count for me.

valeriansaliou commented 2 years ago

Thank you for the PR. The label has been added. I'm currently in holidays / so AFK, I'll review and merge this when I am back.

trkohler commented 2 years ago

thanks, sure. no hurry!

just FYI, that's from the hacktober site:

MUST BE IN A REPO TAGGED WITH THE “HACKTOBERFEST” TOPIC, OR BE LABELED “HACKTOBERFEST-ACCEPTED.”

probably label needs to be changed to hacktoberfest-accepted to be counted because I guess there is some robot watching those and currently this PR is not counted in the dashboard.

valeriansaliou commented 2 years ago

Label updated, is it okay now?

trkohler commented 2 years ago

yes! it's accepted by hacktoberfest, now I would patiently wait for you to be back and review.

trkohler commented 2 years ago

@valeriansaliou gentle ping on my PR in case you forgot about it đź‘€

valeriansaliou commented 2 years ago

Still in holidays, it’s on my todo to review no worries ;)

valeriansaliou commented 2 years ago

Will merge now, some refactors are on the way, eg. moving the LIST command from the Control channel to the Search channel.

valeriansaliou commented 2 years ago

Released Sonic v1.4.0 w/ the LIST command available in search mode. Also added support for .list() in node-sonic-channel. Thanks for all!