search

valeriupredoi / bgcval2

Package for BGCVal v2.0
3 stars 0 forks source link

Pep8 linting #107

Open ledm opened 1 year ago

ledm commented 1 year ago

Ran a linter, and a few refactors over bgcval2.

Code should be cleaner and more readable, but a lot of changes to review.

Happy to do it in stages.

Closes #106

valeriupredoi commented 1 year ago

@ledm thanks to you we now have a "standards" label, although am a bit scared to look at this PR just yet :rofl:

valeriupredoi commented 11 months ago

@ledm this is starting to become stale, mate. You reckon we can just power on sometime and get it over the finish line? I can help with it since I have to yapf a whole lot of code for the ANCIL project too

ledm commented 11 months ago

I think the tests are currently failing because they reference some of the objects that were renamed in this PR. I'll see what I can do.

Edit. nope, jsut me being stupid.

valeriupredoi commented 11 months ago

nice! Then you reckon is close to merge? I can plop a flake8 test then - that'll say "look how standardy and PEPy this package is"