search

valheimPlus / ValheimPlus

A HarmonyX Mod aimed at improving the gameplay and quality of life of the game Valheim.
http://valheim.plus
GNU Affero General Public License v3.0
967 stars 236 forks source link

[BUG] Not importing default values for unused sections #763

Open moinphyst opened 1 year ago

moinphyst commented 1 year ago

Some Valheim Plus settings for the client on a local game will carry across to a Valheim Plus server when the settings are unused. ie Unarmed Damage & Guardian Buff CD/Duration.

A clear and concise description of what the bug is and how you found it.

I found this bug by playing around with settings for a local world. I increased the duration and reduced the duration of the Guardian Buff as well as increased the base unarmed attack damage. I found that when I logged into a shared dedicated server after playing in a local game, these settings remained in effect. Restarting the client removes the settings until entering a local game again.

Steps for the devs to reproduce the behavior:

  1. Go to 'valheim_plus.cfg' for the windows client
  2. Change 'baseUnarmedDamage = 700'
  3. Save and log into a local Valheim game.
  4. Log out of the local Valheim game and enter a dedicated server running Valheim plus not using the settings under the 'Player' section.
  5. Notice that the base unarmed damage is still 700.

I expected the base unarmed damage and guardian buff duration/cd to return to their default values when entering a server that does not have a value different to the default.

My client settings: https://pastebin.com/VgKceZzt

No other mods are being used. A friend is hosting the dedicated server through a service.

KleskReaver commented 1 year ago

To my understanding the values in your local file don't change when joining a server, the servers config settings still apply to your game (basically ignoring your local config). Not sure if this is reflected in the Bepinex console window or not, have not tested this