validator-labs / validator-plugin-network

validator-plugin-network validates your network and creates ValidationResults for validator to consume.
https://validator-labs.github.io/docs
Apache License 2.0
3 stars 0 forks source link

feat!: Support both inline and secret-ref based auth for http file rules #270

Closed ahmad-ibra closed 2 months ago

ahmad-ibra commented 2 months ago

Issue

Resolves https://github.com/validator-labs/validator-plugin-network/issues/263

Description

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/controller/networkvalidator_controller.go 14.28% 6 Missing :warning:
pkg/validate/validate.go 33.33% 1 Missing and 1 partial :warning:
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   38.73%   34.23%   -4.50%     
==========================================
  Files           7        7              
  Lines         395      406      +11     
==========================================
- Hits          153      139      -14     
- Misses        228      254      +26     
+ Partials       14       13       -1     
Files with missing lines Coverage Δ
api/v1alpha1/networkvalidator_types.go 24.07% <100.00%> (-35.93%) :arrow_down:
pkg/http/http.go 81.48% <100.00%> (ø)
pkg/validate/validate.go 79.31% <33.33%> (ø)
internal/controller/networkvalidator_controller.go 44.23% <14.28%> (-1.77%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b8314e...4c0a921. Read the comment docs.