Make io.Driver expose public dontSwallowBom(), and use it in the testharness

validator / htmlparser

The Validator.nu HTML parser https://about.validator.nu/htmlparser/

Other

56 stars 26 forks source link

Make io.Driver expose public dontSwallowBom(), and use it in the testharness #37

Closed sideshowbarker closed 3 years ago

sideshowbarker commented 4 years ago

This change makes nu.validator.htmlparser.io.Driver instances have a dontSwallowBom() method exposed.

Otherwise, without this change, it’s not possible for users of io.Driver to preserve the BOM in input.

This PR branch also has a related change for the testharness. Without that change, the following html5lib-tests case fails:

https://github.com/html5lib/html5lib-tests/blob/master/tokenizer/domjs.test#L197 (“leading U+FEFF must pass through”)

hsivonen commented 3 years ago

I pushed this via the command line as a0c0a75648a9e9aaca61be044043a567af4483ca and now I don't know how to make the GitHub PR metadata say merged instead of closed.

Thanks and sorry about the bad metadata state.