validator / htmlparser

The Validator.nu HTML parser https://about.validator.nu/htmlparser/
Other
56 stars 26 forks source link

Set default lastStartTag in TokenizerTester #38

Closed sideshowbarker closed 3 years ago

sideshowbarker commented 4 years ago

This change causes TokenizerTester to set a default lastStartTag value for any test which has a initialStates value but no lastStartTag value.

Otherwise, without this change, the tokenizer is never actually run for such missing-lastStartTag tests — which results in us failing 5 tests from the html5lib-tests suite.


The html5lib-tests cases which fail without this change are the following:

hsivonen commented 3 years ago

I pushed this via the command line as 23a8b13439f65a4e0cb963075cef78661aed264e and now I don't know how to make the GitHub PR metadata say merged instead of closed.

Thanks and sorry about the bad metadata state.