valit-stack / Valit

Valit is dead simple validation for .NET Core. No more if-statements all around your code. Write nice and clean fluent validators instead!
MIT License
322 stars 26 forks source link

Added missing Required method on string type. #130

Closed GooRiOn closed 7 years ago

GooRiOn commented 7 years ago

Info

This Pull Request is related to issue no. #128

It turned out that we had Required() method for string which was simply put inside Property extensions (since it referce to all reference types) but it didn't support string.Empty. Therefore after adding Required() for string I had to change two unit tests.

Changes

codecov[bot] commented 7 years ago

Codecov Report

Merging #130 into develop will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #130      +/-   ##
===========================================
+ Coverage    99.85%   99.85%   +<.01%     
===========================================
  Files           36       36              
  Lines          698      699       +1     
===========================================
+ Hits           697      698       +1     
  Misses           1        1
Impacted Files Coverage Δ
src/Valit/ValitRuleStringExtensions.cs 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d0059e...755f8d2. Read the comment docs.

GooRiOn commented 7 years ago

fixed