search

valohai / valohai-cli

:heavy_dollar_sign: Command line client for Valohai
MIT License
14 stars 8 forks source link

Create a make recipe to run lint #283

Closed teroyks closed 1 year ago

teroyks commented 1 year ago

Linting still done with pre-commit under the hood. Add pre-commit installation to make dev so that a separate installation step is not needed.

codecov[bot] commented 1 year ago

Codecov Report

Merging #283 (4fe7c39) into master (8ef1fbe) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files         125      125           
  Lines        4194     4194           
  Branches      639      639           
=======================================
  Hits         3635     3635           
  Misses        384      384           
  Partials      175      175

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

teroyks commented 1 year ago

@ruksi re: previous PR – I would prefer make recipes as well – wasn’t sure if the goal is to move away from make, but here it is anyway. 😄