valpackett / soundfixer

A WebExtension that lets you fix sound problems in e.g. YouTube videos
https://addons.mozilla.org/firefox/addon/soundfixer/
The Unlicense
220 stars 34 forks source link

Default settings #56

Open tikitiki2 opened 10 months ago

tikitiki2 commented 10 months ago

i saw that someone had requested to be able to set default settings. i added this functionality. not experienced in extension development or JavaScript so i hope to get some criticism but it seems to be working for me. I added storage using the storage api to store settings so when you hit the set default button it takes the current settings and saves them in local storage then the next time the app is run it reads the storage values and sets them. when you click the reset button it clears the storage and works as it normally would. hope its good.

valpackett commented 10 months ago

Pretty sure what people want is not a button that would both save and restore (?) but rather a default being applied automatically, from a background script or directly from the content script if that works; not from the popup script. Also, there should be an option to only apply the settings per domain. Honestly it would be easier for me to do it myself than to guide someone towards a good implementation, but if you want a learning experience, I can go along with this a bit :) The first tip is respecting the existing code style of a project: no one likes PRs that randomly introduce formatting changes.

tikitiki2 commented 10 months ago

so you mean i should created a separate script file for this functionality and have it so it runs in the background when someone starts the app. having it set by domain is a good idea ill try that too. thanks for the feedback