valu-digital / wp-graphql-cache

Flexible caching framework for WPGraphQL
GNU General Public License v2.0
42 stars 8 forks source link

Missing response headers when data is served from the cache #2

Open toriphes opened 4 years ago

toriphes commented 4 years ago

Thank you for the great work!

Response headers setted with wp-graphql filters like graphql_response_headers_to_send or graphql_access_control_allow_headers are ignored when data is served from the cache.

I used this code as a workaround.

add_action( 'graphql_cache_early_response', function() {
    WPGraphQL\Router::set_headers();
} );

Wouldn't it be better to insert WPGraphQL\Router::set_headers() exactly before calling the respond_and_exit method of the QueryCache class?

DevWael commented 2 years ago

I'm facing the same issue!