search

valyala / fasthttp

Fast HTTP package for Go. Tuned for high performance. Zero memory allocations in hot paths. Up to 10x faster than net/http
MIT License
21.91k stars 1.76k forks source link

client: deprecate misspelled 'MaxIdemponentCallAttempts' #1681

Closed alexandear closed 10 months ago

alexandear commented 11 months ago

This PR deprecates misspelled client's constant DefaultMaxIdemponentCallAttempts and field MaxIdemponentCallAttempts. The changes are backward-compatible. New tests are not needed because existing tests already cover usages of misspelled constant and field.

erikdubbelboer commented 10 months ago

Thanks for the contribution but I don't think we should merge this. The API surface of fasthttp is already much too big. We wouldn't just be able to remove the old ones without breaking backwards compatibility. I guess we'll just have to live with some minor misspellings.