search

valyala / fasthttp

Fast HTTP package for Go. Tuned for high performance. Zero memory allocations in hot paths. Up to 10x faster than net/http
MIT License
21.91k stars 1.76k forks source link

feat:support zstd compress and uncompressed #1701

Closed Max-Cheng closed 9 months ago

Max-Cheng commented 9 months ago

Tests are failing.

Cause compress is declaring go.mod' withgo 1.19'. In this case, I'll downgrade the version.

erikdubbelboer commented 9 months ago

Still failing.

Max-Cheng commented 9 months ago

Still failing.

Ok. Looks like 1.18 encoding/binary does not implement AppendByteOrder. 1.18 1.19

I will fix this in other ways.

gaby commented 9 months ago

Compress minimum Go version is 1.19, downgrading is not a good idea since it will not have the corruption fixes made to zstd recently.

@erikdubbelboer Any timeline for fasthttp to bump the min go version?

erikdubbelboer commented 9 months ago

I'm ok with you dropping 1.18 support in this pull. It's not officially maintained by the Go team either.

Max-Cheng commented 9 months ago

Please Hold. I'll fix this wrong commiter by rebase

Max-Cheng commented 9 months ago

@erikdubbelboer fixed,need squash those commit?

gaby commented 9 months ago

@erikdubbelboer The timeouts in the tests are too agressive. The same error happens in a different PR

https://github.com/valyala/fasthttp/actions/runs/7881870997/job/21506194694?pr=1720

gaby commented 9 months ago

@alexandear @erikdubbelboer @Max-Cheng Can someone rebase with master to see what's left on this PR?

gaby commented 9 months ago

@erikdubbelboer If you add this to the lint workflow before the job, it will show you here on Github where the issues are:

permissions:
  # Required: allow read access to the content for analysis.
  contents: read
  # Optional: allow read access to pull request. Use with `only-new-issues` option.
  pull-requests: read
  # Optional: Allow write access to checks to allow the action to annotate code in the PR.
  checks: write

Example: https://github.com/gofiber/fiber/blob/main/.github/workflows/linter.yml

erikdubbelboer commented 9 months ago

@gaby thanks for the suggestion. I think everything is fixed now and this can be merged.