search

vanessa-king / UBC_LAIR

Collection of standard analysis functions used in the LAIR
2 stars 1 forks source link

VS01A: it's not plotting forward and backward properly #165

Closed jsk2355 closed 1 week ago

jsk2355 commented 2 weeks ago

When it is used to plot dIdV_fwd and dIdV_bwd, for example, two graphs are identical so the generated plot shows one graph. We need to check if the loading block is correctly reading the backward data first, and then check the plotting function used in VS01A block to solve the problem.

jsk2355 commented 2 weeks ago

I tested and it seems it's doing its job. The fwd and bwd are plotted properly. I'll test more grids but Dong, please check it again. If you still get identical fwd and bwd plots then we can go over together.

jsk2355 commented 2 weeks ago

I found that fwd&bwd plots fwd as bwd and vice versa. It was a simple layout case problem. Somehow IV_fwdbwd and dIdV_fwdbwd assigned the first plot to be "bwd" and the the next to be "fwd", even though we usually put forward data as a first variableIn to plot and then optional one to be backward data. I'll update the comment in the mainTrunk for users.

jsk2355 commented 1 week ago

Dong and I tested the block together and we agree that it works fine.