search

vanilla-music / vanilla

Vanilla Music Player for Android
GNU General Public License v3.0
1.19k stars 297 forks source link

Add "Move to top" and "Move to bottom" to the queue context menu #1073

Closed kaipoethkow closed 3 years ago

kaipoethkow commented 3 years ago

This implements "Move to top" and "Move to bottom" items in the queue context menu. After having used both Vanilla as well as AntennaPod for several years I noticed that I use these functions frequently in AntennaPod and missed them in Vanilla. The use case is that users who somehow ended up with a long queue of songs may want to extract a ~handful of songs, move them to the end of the queue in order to listen to, as it were, an ad-hoc best of selection without explicitly working with custom playlists.

Icons for the context menu are included for all resolutions (derived as recolored and rotated "next track" icons).

Limitation: Only includes english and german strings. So most translations are missing.

adrian-bl commented 3 years ago

Looks good to me: but do you have an SVG for the icons?

We tend to keep an SVG for every icon around to be able to regenerate our icons once a new display resolution is available/needed. (Merging this for now since this is a minor issue that can be corrected later).

kaipoethkow commented 3 years ago

Thank you! Sure, I can add the SVG files. What is the best way to do it? Should it be a new PR or is it possible to reopen this one?

adrian-bl commented 3 years ago

Open a new PR - or just add a comment with the link where the file can be downloaded so that i can add it myself