Seekbar does not display when no cover art

[opusforlife2]

• Vanilla Music Version (Settings -> About): 1.0.91
• Android Version: 10 (LOS 17.1)
• Phone vendor / model: Xiaomi Mi 5
• Application was downloaded from (use [x]):
  • [ ] Play Store
  • [x] F-Droid
  • [ ] Other (Nightly Build)
• Did this work in a previous version?
  • [ ] Yes
  • [ ] No
  • [x] NA / Don't know.

Description

The seekbar is only visible when the track playing has a cover art and the notification is in expanded state. When there is none, the notification shrinks and becomes compact, leaving only the 3 action buttons, and no arrow button to expand it, either.

For reference, Poweramp shows an expanded notification even if there is no cover art.

[adrian-bl]

Hmm, this works for me on LOS 18.1

Are you sure that you cant expand the notification by dragging it?

1.0.91 uses the appcompat notification, so it would be very strange if this was only broken on Android 10 but not 11

[opusforlife2]

@adrian-bl Yeah, I just tried it again. There is no expansion arrow to tap, and expanding by trying to drag downwards doesn't work either.

[adrian-bl]

Interesting: i can reproduce this on LOS17 too - that's just silly :-/

Well.. i guess we can just give Android a fake / placeholder cover

[opusforlife2]

Thanks!

[adrian-bl]

This should be fixed with 4c290f0e3fc30f58a0159535bf59979c0fc02333

[opusforlife2]

@adrian-bl Thanks! The notification now stays expanded, making the seekbar available. However, it is bright white in colour, even when system theme is set to dark, making it contrast jarringly with other dark themed notifications.

Do you want me to open a new issue for this?

[adrian-bl]

However, it is bright white in colour, even when system theme is set to dark

I don't think that the notification itself should follow the app theme - it should follow the system theme, which it does on Android 11.

But i've submitted cf9aa1df0ea42451e6720545aa2dc6a5c7f23399 which changes the notification to use the same icon as the widgets do (+ the library view) - which happens to be dark.

[opusforlife2]

Ah. Thanks. Hopefully that works.

Confusingly, both my app theme and system theme happened to be dark, but I still got a white notification for some reason.

[opusforlife2]

@adrian-bl Could you release a new version with this fix soon? Seeing the contrast all the time is pretty discomforting.

[opusforlife2]

@adrian-bl Hi. Sorry to ask this again, but I've been using the bright white notification for many months now. Could you please release the new version since it's already fixed in the code?

[opusforlife2]

@adrian-bl Ping.

[opusforlife2]

@adrian-bl Biannual ping.