search

vanilla-music / vanilla

Vanilla Music Player for Android
GNU General Public License v3.0
1.19k stars 297 forks source link

ogg files do not play on my SM-T713 running Android 9 #990

Open stuart12 opened 5 years ago

stuart12 commented 5 years ago

Vanilla Music can no longer play ogg files on my Samsung tablet. It can play mp3 files. VLC can play the ogg files that Vanilla Music cannot play. I think that playing ogg files with Vanilla Music stopped working when I upgraded from LineageOS 15 to LineageOS 16 but I am not certain. It is possible that they never worked on this tablet.

I can play the same ogg files on my Huawei telephone (running Vanilla Music 1.0.84 and Android 9/LineageOS 16.0)

Steps to reproduce the issue

Try to play an ogg file on a Samsung SM-T713 running LineageOS 16.0 (1 Octobrer 2019). Vanilla Music will show that it is opening the track by indicating the metadata and quickly move to the next track. This happens until it finds a mp3 file that it will then play normally.

Screenshot / Video (If applicable)

The exception seems to be:

[vendor/qcom/proprietary/mm-audio-noship/audio-effects/safx/android-adapter/qcvirt/qcvirt.c:568] Assertion fail: pConfig->inputCfg.format == AUDIO_FORMAT_PCM_16_BIT

stuart12 commented 5 years ago

While Vanilla Music is trying to play ogg files I also see

[vendor/qcom/proprietary/mm-audio-noship/audio-effects/safx/android-adapter/qcbassboost/qcbassboost.c:515] Assertion fail: pConfig->inputCfg.format == AUDIO_FORMAT_PCM_16_BIT

[vendor/qcom/proprietary/mm-audio-noship/audio-effects/safx/android-adapter/qcreverb/qcreverb.c:532] Assertion fail: pConfig->inputCfg.format == AUDIO_FORMAT_PCM_16_BIT

BlackF09 commented 4 years ago

Have the same behavior with my OnePlus Three with LOS 16 although I found a view Ogg-files that are played with VM. I think with LOS 15 it was without a problem like for @stuart12 . VLC plays all my Ogg and mp3-files without problem at any LOS/Android version.

Same behavior with an Android 9 (colorOS / realme X2 pro) (without able to test it with Android 8): Ogg files are being "inspected" for a view seconds then skipped. Some Ogg-files are not even considered playable by VM and therefore not shown in the library.

adrian-bl commented 4 years ago

This is an issue with the ROM: We use the android media framework to play audio: If the system can't handle a certain kind of format, vanilla will not be able to play it.

Sarius997 commented 4 years ago

I saw a similar bugreport on another project a few days ago, which was also about lineage os not being able to play ogg files which they were able to work around by using a custom magisk module.
Link to the comments about the solution: https://github.com/00-Evan/shattered-pixel-dungeon/issues/340#issuecomment-538673813