vannov / pygame_cards

pygame_cards is a Python package for creating simple card games powered by pygame framework.
MIT License
24 stars 12 forks source link

Core changes, replace animation system, two new sample games #4

Open ZBlocker655 opened 3 years ago

ZBlocker655 commented 3 years ago

Here's a large bundle of changes I've been working on in my fork, in case you would like to have them, too. I'll try to list them succinctly:

Incorporate earlier pull request from @apinkney97

I incorporated an earlier pull request to alter the way controllers are instantiated, which also allows for nicer declarations of controller fields.

Changes to card holders

These are generally breaking changes.

New animation system

I replaced the old Controller.moves collection with a Controller.animations collection accompanied by the new animation.py module. See README.md. The new example games make use of all the new animation logic.

I added animation of cards for Klondike.

New sample games

Created new sample games War and Crazy 8s that showcase the following:

ZBlocker655 commented 3 years ago

I like those future suggestions! I haven't done type hints yet, but it looks like a really good idea. I'd be happy to contribute more as well.