vaphes / pocketbase

PocketBase client SDK for python
https://pypi.org/project/pocketbase/
MIT License
331 stars 38 forks source link

Add an error message for trying to connect over HTTP with HSTS enabled #63

Closed Austin-540 closed 8 months ago

Austin-540 commented 1 year ago

Previous error message for this situation:

Screenshot 2023-07-13 at 6 34 18 PM

The previous error message was not related to what I was doing wrong, so it took me a while to realize that the error was coming from the fact that I forgot to use HTTPS.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5540279017


Changes Missing Coverage Covered Lines Changed/Added Lines %
pocketbase/services/record_service.py 1 2 50.0%
<!-- Total: 1 2 50.0% -->
Totals Coverage Status
Change from base Build 5290254865: -0.06%
Covered Lines: 800
Relevant Lines: 843

💛 - Coveralls
m29h commented 1 year ago

Just out of curiosity: what is the HTTP response status code you get along with the Null response data? Is it still status 200? The pocketbase documentation does not list a scenario where response data to auth_with_password may be empty.

Possibly this is a bug in pocketbase itself (or the reverse proxy you use) and not an issue for the client.

Austin-540 commented 1 year ago

Screenshot 2023-07-17 at 10 08 59 AM

I'm using a cloudflare tunnel, instead of directly connecting to pocketbase

m29h commented 8 months ago

Given that this PR is not solving an issue with pocketbase itself but rather an cloudflare tunnel error code I close due to inactivity