vaphes / pocketbase

PocketBase client SDK for python
https://pypi.org/project/pocketbase/
MIT License
331 stars 38 forks source link

fixes #65 issue when expanding list of multiple relations #66

Closed m29h closed 1 year ago

m29h commented 1 year ago

This adds both a integration test case for multiple relation expansion as well as resolves #65

we did not handle the case where the expansion is a list of records instead of a single record directly

Note: this only pushes the uncertainty down to the next layer. Now the value of expand["xxx"] can either be

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5814928105


Totals Coverage Status
Change from base Build 5290254865: 0.1%
Covered Lines: 801
Relevant Lines: 843

💛 - Coveralls
kbruegge commented 1 year ago

So this seems to work. It now returns a list of records. Which for me is absolutely fine.

In [7]: r.expand
Out[7]: {'location': [<Record: 0yoeep2hyh0p57t>]}

Thanks!

Cobryis commented 1 year ago

@vaphes Are you planning on integrating this fix?