coveralls
commented
4 months ago Pull Request Test Coverage Report for Build 9237715857
Details
- 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.03%) to 91.15%
| Totals | |
|---|---|
| Change from base Build 9236847014: | 0.03% |
| Covered Lines: | 838 |
| Relevant Lines: | 892 |
Implemented remaining backup methods:
Support backup restoration.
Support uploading backup.
Required refactoring backup tests.
The backup API seems to be a little different from the other APIs so it was hard to follow the same approach for testing, etc. I reorganized the tests to make cleanup more automatic and reusable. In particular I added some fixtures to the backup service tests, but I did not see a lot of previous use of fixtures so I don't know if that's the way you wish to do that. Just to be sure, I don't mind putting things in ways that match other parts of the project if there is something I am not fitting in to place correctly.
I also learned that the clean up from my previous change was not even working properly :/ I fixed that.