search

vaphes / pocketbase

PocketBase client SDK for python
https://pypi.org/project/pocketbase/
MIT License
331 stars 38 forks source link

httpx too old version #93

Closed Glavnyuk closed 1 week ago

Glavnyuk commented 1 month ago

need bump httpx version to >=0.27.0

jwang-paradise commented 3 weeks ago

I'm having the same issue. This has to do with the poetry dependency spec, in pyproject.toml#L42:

[tool.poetry.dependencies]
httpx = "^0.24.1"

The "^0.24.1" specifier allows only >=0.24.1 and <0.25.0. Ref: Caret requirements - Dependency specification | Documentation | Poetry

Changing it to "^0.24" will allow a wider range of version (>=0.24, <1.0), and should solve this issue.

Hope this can be solved. Much is appreciated!

vaphes commented 3 weeks ago

@Glavnyuk and @jwang-paradise Man I really need coffee today, made a mess on comments and didn't reference this issue on the last PR. Can you check if the issue is solved with the last commit on master?

jwang-paradise commented 3 weeks ago

I built this patch and the requirement in the built package has changed:

+ Requires-Dist: httpx (>=0,<1)
- Requires-Dist: httpx (>=0.24.1,<0.25.0)

Definitely allows newer versions of httpx.

But I'm sorry about the mistake in my last comment: the specifier "^0.24" actually compiled to (>=0,<1), not (>=0.24, <1.0). If httpx versions <0.24 are incompatible, maybe inequality requirements will have to used, i.e. ">=0.24, <1.0".

Otherwise it's perfectly ok. Works fine on my project now!