search

vapor / fluent-postgres-driver

🐘 PostgreSQL driver for Fluent.
MIT License
146 stars 53 forks source link

Shut down the driver's connection pool safely #220

Closed gwynne closed 4 months ago

gwynne commented 4 months ago

These changes are now available in 2.9.2

Specifically, don't use the soft-deprecated AsyncKit API that calls EventLoopFuture.wait() internally; use the one that at least does it with Dispatch (best we can do without changing Fluent's driver interface).

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.77%. Comparing base (e44fcc8) to head (7b04b87).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #220 +/- ## ======================================= Coverage 63.77% 63.77% ======================================= Files 8 8 Lines 334 334 ======================================= Hits 213 213 Misses 121 121 ``` | [Files](https://app.codecov.io/gh/vapor/fluent-postgres-driver/pull/220?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [...es/FluentPostgresDriver/FluentPostgresDriver.swift](https://app.codecov.io/gh/vapor/fluent-postgres-driver/pull/220?src=pr&el=tree&filepath=Sources%2FFluentPostgresDriver%2FFluentPostgresDriver.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9GbHVlbnRQb3N0Z3Jlc0RyaXZlci9GbHVlbnRQb3N0Z3Jlc0RyaXZlci5zd2lmdA==) | `100.00% <100.00%> (ø)` | |
gwynne commented 4 months ago

The TSan failure in the 5.8 CI is a false positive that was fixed in 5.9.