vatesfr / xen-orchestra

The global orchestration solution to manage and backup XCP-ng and XenServer.
https://xen-orchestra.com
Other
795 stars 265 forks source link

Feat(backups): support VTPMs content backup/restore #8139

Closed fbeauchamp closed 1 day ago

fbeauchamp commented 1 week ago

Description

This PR add the support for correctly saving, transfering and restoring the content of VTPMs This call 2 internal/ undocumented APIs methof of the xapi VTPM.get_contents and VTPM.set_contents

The raw content of the VTPM will be written unencrypted in the metadata JSON, use remote encryption at rest if you want to protect this data

tested with and without differential restore :
Capture d’écran du 2024-11-18 15-20-34

Checklist

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.