vatesfr / xen-orchestra

The global orchestration solution to manage and backup XCP-ng and XenServer.
https://xen-orchestra.com
Other
795 stars 265 forks source link

feat(xo-web/backup): long-term retention settings #8141

Closed pdonias closed 1 day ago

pdonias commented 1 week ago

Requires #7999

Screenshots

Capture_2024-11-21_13:51:41

Description

Backup/New: UI for #7999.

Checklist

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.
julien-f commented 1 week ago

Very nice to see progress on this front, I'm eager to see this release :slightly_smiling_face:

But, IMHO, this feature is not trivial to grasp and I feel like releasing it as is may trigger a lot of questions in the forum and support, like:

I think it would be interesting to discuss with @fbeauchamp and @thomas-dkmt and to figure out how to improve, a few suggestions from the top of my head:

IMO, keep it as simple as possible but give enough context to avoid too many questions :slightly_smiling_face:

pdonias commented 1 week ago

Individual tooltips might not be necessary if there's a good description at the top of the card? (@fbeauchamp any idea what the description could be?) And then we can indeed add a "Learn more" link and add more details in the documentation.

MathieuRA commented 3 days ago

IMO, long term retention information should be added in the notes column of Backup/Preview/Backup jobs Also, don't forget to add timezone and longTermRetention in api/backup-ng.mjs#SCHEMA_SETTINGS