search

vatsimnetwork / vatspy-data-project

A home for VATSPY Data updates.
Creative Commons Attribution Share Alike 4.0 International
105 stars 141 forks source link

Changes to YBBB Oceanic Sector #805

Closed alphadelta332 closed 4 months ago

alphadelta332 commented 7 months ago

Description of changes

Changes to YBBB Oceanic Sectors that have occurred recently

Reason and motivation

Recently, changes have been made to the BN-TSN_FSS sector, that involves HWE splitting off from the sector, TSN becoming its own individual sector, and FLD now assuming the rest of what was the TSN sector group (COL, AGGG and ANAU)

To reflect the correct boundaries of the BN-TSN_FSS and BN-FLD_FSS positions

Approved contributior?

NelisV commented 6 months ago

Hey @alphadelta332 @zkgell, you're both not on our approved contributors list, can you verify according to the procedure, or make sure @chrisg06 or @codepip2007 leave a review?

alphadelta332 commented 5 months ago

Just checking how far away this is from getting pushed @ziplock1 @NelisV ? We've got a major event coming up through this airspace in a couple of days, and would be awesome if all the sectors could show correctly. Cheers!

alphadelta332 commented 5 months ago

Hey folks. When opening this in QGIS, i don't see YFLD rendering. This could point to invalid GeoJSON. Did you test in a gis tool?

Yes. I tested in geojson.io, and it didn't render correctly. But when I tested on geojson.tools, it rendered without issue. I have no idea why

EDIT: With further testing, it looks like it was having issues due to the first and last point not being the same. Have fixed this, retested, and still appears to be showing correctly in GeoJSON viewers

Slep-wt commented 4 months ago

These changes are included in PR #836 alongside other internal changes relating to position indentifiers. Can this PR be closed?

NelisV commented 4 months ago

@alphadelta332 @Slep-wt Can this be closed?

alphadelta332 commented 4 months ago

@alphadelta332 @Slep-wt Can this be closed?

If @Slep-wt has included all of this in another PR, I'm happy for it to be closed

Slep-wt commented 4 months ago

@alphadelta332 @Slep-wt Can this be closed?

If @Slep-wt has included all of this in another PR, I'm happy for it to be closed

Was included in #836. Happy for this to be closed.