search

vazco / forminer

Vazco Form Builder Docs
https://forminer.com
1 stars 0 forks source link

FB-324-move-rest-of-the-styles #64

Closed paulinabjacykowska closed 1 year ago

paulinabjacykowska commented 1 year ago

This task is the last part of https://vazco1.atlassian.net/browse/FB-324 - it consists of removing the rest of the styled components and moving all of our styles into custom.css file.

paulinabjacykowska commented 1 year ago

lgtm!

Q: What about the remaining styled-components in LayoutBase and src/globalStyles? It still uses the theme, I thought we wanted to get rid of:

  • styled-components
  • styled-media-query
  • styled-normalize
  • polished

There are problems with moving GlobalStyle from theme.ts to the custom.css (appearance of the website is not the same as before, there are some places, especially in docs and its not that ease to change those styles for the website to look the same as before). Because of that I think it would be best to release this PR to the live hoping, that it will be enough to remove FOUC, and take care of what you wrote above in the future.

mkaliszewski commented 1 year ago

There are problems with moving GlobalStyle from theme.ts to the custom.css (appearance of the website is not the same as before, there are some places, especially in docs and its not that ease to change those styles for the website to look the same as before). Because of that I think it would be best to release this PR to the live hoping, that it will be enough to remove FOUC, and take care of what you wrote above in the future.

Makes sense! Thanks for the update! :rocket: