vdudouyt / stm8flash

program your stm8 devices with SWIM/stlinkv(1,2)
GNU General Public License v2.0
402 stars 182 forks source link

Work around deprecation of libusb_set_debug. #112

Closed mjagdis closed 5 years ago

mjagdis commented 6 years ago

Later versions of libusb mark libusb_set_debug deprecated and introduce a new libusb_set_option instead. Note that libusb_set_debug is only deprecated, not removed, and that this change occurs between libusb 1.0.21 and 1.0.22. Merging this will fix a compile warning but result in binaries that are not necessarily transferable between systems. libusb 1.0.21 is still in widespread usage.

Signed-off-by: Mike Jagdis mjagdis@eris-associates.co.uk (github: mjagdis)

spth commented 5 years ago

Should we care about downward binary compability? Currently, most users will just compile the stm8flash themselves, and are unlikely to downgrade libusb thereafter. Distributions might pick up stm8flash at some point, but the situation should be similar.

Philipp

spth commented 5 years ago

A fix for the deprecation issue has been applied today. I am more worried source compability than binary compability. The fix ensures that stm8flash will compile with future libusb versions that might no longer have libusb_set_debug().

Philipp