veda-consulting-company / uk.co.vedaconsulting.mosaico

Other
39 stars 75 forks source link

Add folder for TinyMCE's translation #644

Open allinappliadmin opened 6 months ago

allinappliadmin commented 6 months ago

Would it be possible to add a folder for the internationalization of TinyMCE: /packages/mosaico/dist/tinymce/langs with the official translation files found here: https://www.tiny.cloud/get-tiny/language-packages/ Each update for the extension on each of our instances implies to re-add this file manually (here for French) fr_FR.js.zip

allinappliadmin commented 1 month ago

Any updates about this? Each new version of Mosaico implies a lot of redondant work to have the translation of TinyMCE back again.

mattwire commented 1 month ago

@allinappliadmin I did merge a French translation PR for 3.6. Are you able to create a PR for the tinymce translation?

allinappliadmin commented 1 month ago

I could try yes. The question would be to automatically package the latest version for each new release if there's an update on TinyMCE.

mattwire commented 1 month ago

I could try yes. The question would be to automatically package the latest version for each new release if there's an update on TinyMCE.

I don't know how to either but that sounds like the right approach :-)

allinappliadmin commented 1 month ago

were should the new 'tinymce' be created? There's no such folder here: https://github.com/civicrm/mosaico/tree/master when in the extension it should be here: uk.co.vedaconsulting.mosaico/packages/mosaico/dist/tinymce/langs

allinappliadmin commented 1 month ago

I can manually download and add the translated files only. To add it programmatically I guess we would have to append the script you use to create the extension file as if I understood well Mosaico itself is downloaded and embedded in the extension.