veeso / suppaftp

a super FTP/FTPS client library for Rust with support for both passive and active mode
Apache License 2.0
112 stars 28 forks source link

feat: Send + Sync trait to AsyncFtpStream/FtpStream #61

Closed newfla closed 10 months ago

newfla commented 10 months ago

45 - Send + Sync traits to AsyncFtpStream/FtpStream

Fixes #45

Description

To make AsyncFtpStream/FtpStream Send+Sync, tls_ctx should be declared as Send+Sync. AsyncTlsConnector and TlsConnector already satisfay Send+Sync traits so no breaking change is expected

List here your changes

Type of change

Please select relevant options.

Acceptance tests

wait for a project maintainer to fulfill this section...

newfla commented 10 months ago

@veeso I've missed a trait bound in both async and sync code. Similarly, Sync trait can be added to make the use of the library much more ergonomic in multi-threaded contexts. Should I prepare a new pr or would you prefer an addition to this one?

veeso commented 10 months ago

@newfla No, I think you can add it here. Thank you in advance