vega / voyager

Visualization Tool for Data Exploration
http://vega.github.io/voyager
Other
1.45k stars 179 forks source link

Uploading json file error #264

Open quantuminformation opened 7 years ago

quantuminformation commented 7 years ago

I tried to upload a json file but get:

Invalid file type. File must be one of following types: [text/csv, text/json, text/tsv]

image the file: image

kanitw commented 7 years ago

Your data should be a row-oriented array of objects describing each item. (See values of this Vega-Lite spec: https://github.com/vega/vega-lite/blob/master/examples/specs/bar.vl.json for the format.

Can you confirm if data of that format work for you? If so we can try to improve our error message to be more descriptive.

However, we're in the process of refactoring Voyager 2 into a React/Redux app which will produce a way more stable codebase, but this mean we will deal with higher priority issues first.

quantuminformation commented 7 years ago

There will always be new frameworks, have you considered a vanilla TypeScript approach to your components, like https://github.com/quantumjs/solar-popup ?

kanitw commented 7 years ago

The main reason we are migrating is that Angular 1's two-way dataflow makes it very hard to maintain internal program state.

I think Redux is a great way to structure the application state. Of course, redux can be used with many framework. But it's mostly widely used with React. Plus, React has a huge community and likely to be maintained given it's widely used for core applications at Facebook and many other community.

quantuminformation commented 7 years ago

Valid reasons. I still advise using vanilla, until you need to use a framework. Your code will always be valid and future proof if done right.