vegaprotocol / frontend-monorepo

Toolkit for building apps that interact with Vega
https://vega.xyz
MIT License
25 stars 16 forks source link

Other tooltips #1358

Closed pennyandrews closed 1 year ago

pennyandrews commented 2 years ago

Story

As a liquidity provider I want to understand what we mean by each of the key types of data displayed So that regardless of the words we use at Vega, it's understood what we mean!

Tasks

Tooltips

Data columns

DETAIL PAGE

MARKET LIST

DATA ITEMS

image

Dashboard sketch for reference https://miro.com/app/board/uXjVOs_PBKk=/?moveToWidget=3458764531971937952&cot=14

Could do each of these as md files that are easily editable by Vega people and maybe a way to easily show or hide the (i) based on whether there is any content for it or not?

Visual styles (only) can be used from this early version of a design https://www.figma.com/file/qgCd4r61Z1r3tUkxKehhmu/Website-Design-Updates?node-id=399%3A20530

ciaran- commented 1 year ago

There's a preview available at this link that's got some of these changes. I've added tooltips for the 4 columns mentioned - and the same 'i' icon we're using elsewhere.

@ckpringle I wonder if we're desperate to keep the icon? I ask because the column titles are already wide enough to be clipping at the default size on my screens, and the icon is obviously an additional thing to try and fit in. Worth saying the Tooltip component that I re-used is designed to make the whole header for a column tooltip-on-hover, so that's what we've got here. The icon is just an additional nudge that it's possible.

Happy to chat - especially if anything I've said above doesn't make much sense.