search

vegaprotocol / vegawallet-browser

A wallet for the Vega protocol implemented as a browser extension for Firefox and Chromium-based browsers.
https://vegaprotocol.github.io/vegawallet-browser/
MIT License
4 stars 1 forks source link

feat: error cases #621

Closed dexturr closed 1 year ago

dexturr commented 1 year ago

Closes #555 #425

As a user Given I have no internet Then I do not want to see an error page And I want to see a warning

github-actions[bot] commented 1 year ago

Here is your approbation coverage BEFORE this PR:

*Criteria*: 197  *Covered*: 191  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 97.0%

Here is your approbation coverage AFTER this PR:

*Criteria*: 197  *Covered*: 191  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 97.0%

AC Diff Report:

There are no changes to AC coverage %, please note any new coverage is ignored by this report IF it retains 100% coverage for the given file.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

dalebennett1992 commented 1 year ago

This occurs when running without the mock and trying to send a transfer via the sample dapp here https://vegaprotocol.github.io/vegawallet-browser/

Here is the error image "Error: Asset with id fc7fd956078fb1fc9db5c19b88f0874c4299b2a7639ad05a47a28c0aef291b55 not found\n at getAssetById (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:112038:20)\n at useFormatAssetAmount (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:112435:24)\n at EnrichedTransferView (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:112449:42)\n at renderWithHooks (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:21100:20)\n at mountIndeterminateComponent (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:24864:15)\n at beginWork (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:26377:18)\n at beginWork$1 (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:32201:16)\n at performUnitOfWork (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:31335:14)\n at workLoopSync (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:31241:7)\n at renderRootSync (chrome-extension://jfaancmgehieoohdnmcdfdlkblfcehph/popup.js:31209:9)"

is this the kind of scenario we are attempting to handle?

dexturr commented 1 year ago

merged into #580