vegaprotocol / vegawallet-browser

A wallet for the Vega protocol implemented as a browser extension for Firefox and Chromium-based browsers.
https://vegaprotocol.github.io/vegawallet-browser/
MIT License
4 stars 1 forks source link

test: fix resiliency race condition #651

Closed dexturr closed 1 year ago

dexturr commented 1 year ago

There was a race condition where if there server did not start before the test ran no healthy node could be found resulting in errors. We now only navigate to the app after we have started the server to prevent this happening.

Refactored the files so that each set of resiliency behaviour in it's own file

github-actions[bot] commented 1 year ago

Here is your approbation coverage BEFORE this PR:

*Criteria*: 224  *Covered*: 218  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 97.3%

Here is your approbation coverage AFTER this PR:

*Criteria*: 224  *Covered*: 218  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 97.3%

AC Diff Report:

There are no changes to AC coverage %, please note any new coverage is ignored by this report IF it retains 100% coverage for the given file.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information