search

vegaprotocol / vegawallet-browser

A wallet for the Vega protocol implemented as a browser extension for Firefox and Chromium-based browsers.
https://vegaprotocol.github.io/vegawallet-browser/
MIT License
4 stars 1 forks source link

fix: fix cpu spike in firefox #659

Closed emilbayes closed 11 months ago

emilbayes commented 11 months ago

Looking at a firefox profile, JSON-RPC responses were being fed back into the server, causing an infinite (but async) loop of responses being parsed as requests, yielding errors. Another small change is early return when the pending messages in the queue is zero.

github-actions[bot] commented 11 months ago

Here is your approbation coverage BEFORE this PR:

*Criteria*: 224  *Covered*: 218  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 97.3%

Here is your approbation coverage AFTER this PR:

*Criteria*: 225  *Covered*: 219  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 6  *Coverage*: 97.3%

AC Diff Report:

New spec files and their coverage:

1133-KPAL-keepalive.md 100% coverage
sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information