search

vegaprotocol / vegawallet-browser

A wallet for the Vega protocol implemented as a browser extension for Firefox and Chromium-based browsers.
https://vegaprotocol.github.io/vegawallet-browser/
MIT License
4 stars 1 forks source link

Chore/other networks #701

Closed dexturr closed 9 months ago

dexturr commented 9 months ago

Add support for the other networks in Vega hidden behind a setting

dexturr commented 9 months ago

Needs an e2e test

github-actions[bot] commented 9 months ago

Here is your approbation coverage BEFORE this PR:

All ACs: *Criteria*: 300  *Covered*: 290  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 10  *Coverage*: 96.7%

Here is your approbation coverage AFTER this PR:

All ACs: *Criteria*: 303  *Covered*: 292  *by/FeatTest*: -  *by/SysTest*: -  *Uncovered*: 11  *Coverage*: 96.4%

AC Diff Report:

Spec files decreased in % coverage:

1107-SETT-settings.md by 9.00%

WARNING:

You have files with decreased AC coverage. This should not be happening. Please investigate the following files:

1107-SETT-settings.md
sonarcloud[bot] commented 9 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
70.6% Coverage on New Code (required ≥ 75%)
29.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud