search

venmo / DVR

Network testing for Swift
http://blog.soff.es/network-testing-in-swift-with-dvr
MIT License
651 stars 86 forks source link

Update to Swift 3 #60

Closed soffes closed 7 years ago

soffes commented 7 years ago

⚠️ The two upload tests are currently failing so I commented them out. We should fix those before merging this.

rhysforyou commented 7 years ago

@soffes looks like you need to remove the TOOLCHAINS environment variable from .travis.yml, otherwise it's trying to build and test against Swift 2.3.

armstrongnate commented 7 years ago

I fixed the upload tests in https://github.com/soffes/DVR/pull/1.

codeOfRobin commented 7 years ago

@soffes @n8armstrong Any ETA on when this'll be ready for production?

eliperkins commented 7 years ago

@soffes @hyperspacemark @florin-pop @n8armstrong how do y'all feel about getting this PR up to date and merged into master? I feel like people have been using the swift-3 branches/forks for long enough to vet them. It'd be great to get things like @n8armstrong's fixing of the upload tests and everyone else's work into master soon!

brentleyjones commented 7 years ago

Would love to have this merged!