respect appearance settings

venmo / VENTouchLock

A Touch ID and Passcode framework used in the Venmo app.

MIT License

964 stars 114 forks source link

respect appearance settings #35

Closed zinthemoney closed 9 years ago

zinthemoney commented 9 years ago

When VENTouchLockSplashViewController subclass sets self.touchLock.appearance.splashShouldEmbedInNavigationController = NO; (default is also NO.) During unlocking, a user chooses Enter Passcode, the enter passcode view controller should not be embedded.

dasmer commented 9 years ago

@zinthemoney Thanks for the PR!

I think splashShouldEmbedInNavigationController works as expected since the VENTouchLockSplashViewController is not embedded in a navigation controller when its set to NO

Instead, maybe we create another appearance boolean passcodeViewControllerShouldEmbedInNavigationController to specify whether or not the passcode view controller is in a navigation controller.

zinthemoney commented 9 years ago

@dasmer nice suggestions! I added passcodeViewControllerShouldEmbedInNavigationController.

dasmer commented 9 years ago

@zinthemoney Thanks! this is great :smiley: