search

venmo / VENTouchLock

A Touch ID and Passcode framework used in the Venmo app.
MIT License
964 stars 114 forks source link

Nil result for parentSplashViewController #6

Closed coneybeare closed 10 years ago

coneybeare commented 10 years ago

While debugging why recordIncorrectPasscodeAttempt was never called, I traced through the framework and found that parentSplashViewController is always nil. This is reproducible 100% in the sample app as-is.

I think the solution is to edit this line to return navController instead of nil if a navigation controller is not found, or at least do some more robust checking to determine the parent.

dasmer commented 10 years ago

@coneybeare

You're right! #8 resolves this issue. I'm just waiting for Travis to give me the green light before I merge. Thanks for discovering this and reporting it! :smile: